robrix icon indicating copy to clipboard operation
robrix copied to clipboard

Title Bar Title Buttons Not Visible on Windows and Maximizing Does Not Respect Taskbar View on Windows

Open smarizvi110 opened this issue 6 months ago • 8 comments

https://github.com/user-attachments/assets/6363541c-8dc4-4707-8bfa-0a3d289fc8c1

Hello!

Based on the attached video, the title bar title and the buttons for closing, maximizing/restoring, and minimizing a window are not visible. Furthermore, upon maximizing the window, the taskbar is covered up by the Robrix window, even though it should respect the taskbar view and not cover it.

Would be happy to look into this myself with any insight anyone would have to share!

smarizvi110 avatar May 22 '25 14:05 smarizvi110

~~Odd, it is normal in my windows 10 1809.~~

Same issue on my windows 10 1809.

aaravlu avatar May 23 '25 17:05 aaravlu

Is it a bug recent commit caused?

Is it normal previous?

aaravlu avatar May 23 '25 17:05 aaravlu

Is it a bug recent commit caused?

Is it normal previous?

Not entirely sure. This is on cloning main and running it on the latest Windows 11 build. Can report system details here if needed

smarizvi110 avatar May 24 '25 08:05 smarizvi110

Not entirely sure. This is on cloning main and running it on the latest Windows 11 build. Can report system details here if needed

Thanks, now i can confirm this issue was recent commit caused.

aaravlu avatar May 25 '25 04:05 aaravlu

@kevinaboos , currently robrix relies on the makepad library you forked, sync your makepad fork's commit with the lastest upstream can resolve this issue.

aaravlu avatar May 26 '25 08:05 aaravlu

Thanks for the report @smarizvi110, and thanks @aaravlu for identifying that this has been fixed in makepad already. I will update the fork that Robrix depends on and then report back here.

kevinaboos avatar May 27 '25 16:05 kevinaboos

@kevinaboos , currently robrix relies on the makepad library you forked, sync your makepad fork's commit with the lastest upstream can resolve this issue.

Actually, @aaravlu, what branch (or specific commit) fixed this? I don't see anything related to it on the upstream makepad/makepad/dev branch.

kevinaboos avatar May 27 '25 16:05 kevinaboos

I have just updated Robrix to the very latest Makepad (see #501). Let me know if that fixes this problem.

kevinaboos avatar May 29 '25 16:05 kevinaboos

Fixed by #523.

kevinaboos avatar Jun 28 '25 00:06 kevinaboos