robrix icon indicating copy to clipboard operation
robrix copied to clipboard

RoomScreen's set_displayed_room is called during MobileUi's draw_walk

Open alanpoon opened this issue 7 months ago • 1 comments

RoomScreen set_displayed_room is called during draw_walk, resulting it to be called multiple times in MobileUi.

Image

alanpoon avatar May 22 '25 02:05 alanpoon

yeah, the mobile UI follows more of an immediate drawflow. This isn't necessarily problematic though, since set_displayed_room() doesn't do anything if the same room is being displayed again.

Do you observe a problem with this design? We could certainly modify it to only do this if the view is actually being changed.... but I don't think it's making a large impact.

kevinaboos avatar May 27 '25 16:05 kevinaboos

Closing because I think this is not an error, just an observation. Feel free to re-open if this is actually problematic.

kevinaboos avatar Jun 13 '25 17:06 kevinaboos