project-robius
When showing the EditingPane, we should temporarily save the `replying_to` state somewhere and hide the reply preview view, as it can be confusing to the user why that is still there while they're editing an unrelated message.
- Then, after the EditingPane is hidden, we can re-display the
replying_topreview, which is easy and sensible because we're already re-displaying the existing input_bar TextInput state. - We could also optionally do the same thing for the
LocationPreview, and really, any other components that exist in the input_bar overlay parent view.
@kevinaboos
IMHO, It is better to be:
Once user open EditingPane, if replying_to pane is opening, save its state somewhere & close replying_to pane.
Contrarily, Once user open replying_to pane, if EditingPane pane is opening, save its state somewhere & close EditingPane pane.
Sorry, i am a little pulzle about the state you mentioned above.
IMHO, the state should contains 1. The string inside the input bar & 2. The message it replies to or editing (TimelineEventId)
@kevinaboos IMHO, It is better to be: Once user open
EditingPane, ifreplying_topane is opening, save its state somewhere & closereplying_topane. Contrarily, Once user openreplying_topane, ifEditingPanepane is opening, save its state somewhere & closeEditingPanepane.
Yes, I agree. That sounds like exactly the same thing as what I wrote in the original issue... how is it different?
Typically you don't close an issue until the PR that resolves that issue gets merged in itself. That will automatically happen too, so you don't need to do it manually.
Typically you don't close an issue until the PR that resolves that issue gets merged in itself. That will automatically happen too, so you don't need to do it manually.
Yeah, fully agree.
I mean, compare to this issue, #519 is an enhanced version, where I made question clearer.
Ah ok, I see, sorry about that. Typically the "Closed by #XYZ" language is reserved for a PR that addresses an issue.
I'll leave this one open since it provides a bit more context, but will link to #519.