robrix icon indicating copy to clipboard operation
robrix copied to clipboard

After installing robix on the window system, always bring a console window when starting.

Open yangcancai opened this issue 9 months ago • 9 comments

Issuse

After Installing the robix-window-x64.setup.exe in window system, when click the robix.exe, will alway find a console window . The friendly purpose is only show the GUI window, so need to hidden the console window alway.

Image

yangcancai avatar Feb 27 '25 02:02 yangcancai

Thanks, I agree with this change. See my comments in #410.

I'm marking this as blocked-on-makepad because this feature should be implemented as a cfg option within Makepad itself.

kevinaboos avatar Feb 28 '25 19:02 kevinaboos

@yangcancai are you interested in implementing this in Makepad itself? If not, let me know and I can contribute that change myself, and then we can come back here and use that Makepad feature within Robrix.

kevinaboos avatar Mar 03 '25 23:03 kevinaboos

Very happy to contribute

yangcancai avatar Mar 14 '25 07:03 yangcancai

@kevinaboos I checked the relevant documentation of rust, and it seems that the windows_subsystem attribute can only be used in the main module. could you help me ?

yangcancai avatar Mar 17 '25 08:03 yangcancai

@kevinaboos I checked the relevant documentation of rust, and it seems that the windows_subsystem attribute can only be used in the main module. could you help me ?

Sure, sorry for the delay, I totally missed this.

What do you mean by "the main module"? I haven't looked into this so I'm not familiar with that term.

kevinaboos avatar Apr 20 '25 18:04 kevinaboos

@kevinaboos the main module means #![windows_subsystem = "windows"] must be used in the main.rs file.

yangcancai avatar Apr 21 '25 10:04 yangcancai

I see. Due to how cargo works, Makepad has to use a "stub" called app_main (generated via a macro) to act as the entry point across various platforms.

@yangcancai You could try adding that #![windows_subsystem = "windows"] attribute to the top of main.rs in robrix. I'm not very familiar with windows subsystems, so if that doesn't work, then we can try to modify Makepad itself. But Makepad doesn't really define the main.rs module — each app does that individually — so it doesn't seem like a Makepad-internal solution.

kevinaboos avatar May 27 '25 20:05 kevinaboos

reopen this https://github.com/project-robius/robrix/pull/410 can fix it #

yangcancai avatar May 29 '25 01:05 yangcancai

ok sure, I reopened #410. I had forgotten about that issue.

Assuming we are okay with allowing one line of platform-specific code in Robrix, #410 still isn't ready to be merged in yet. I left another review there describing what changes need to be made to #410.

kevinaboos avatar May 29 '25 20:05 kevinaboos

Closed by #410

kevinaboos avatar Jun 21 '25 00:06 kevinaboos