robrix icon indicating copy to clipboard operation
robrix copied to clipboard

Not handling tombstone room

Open alanpoon opened this issue 9 months ago • 4 comments

  1. When changing a room to tombstone room, there is failedToParseState in the events in the timeline.
  2. Missing notification: "This room has been replaced and is no longer active."
  3. Missing Link to link to new room: "The conversation continues here"
  4. Should not allow anymore messaging.

For instruction on how to tombstone a room: https://ems-docs.element.io/books/element-cloud-documentation/page/frequently-asked-questions#bkmrk-manual-tombstone

Image

alanpoon avatar Feb 26 '25 08:02 alanpoon

https://github.com/matrix-org/matrix-rust-sdk/pull/4211#issuecomment-2461411988

It seems like there is state event for tombstone room, but there is parse error.

alanpoon avatar Feb 26 '25 08:02 alanpoon

Ignore ParseError as I needed to add a body field.

alanpoon avatar Feb 26 '25 13:02 alanpoon

Image After checking with Element X, element X also has not handled tombstone room. It is because room.is_tombstone() returns false.

Ways to determine if a room is tombstone:

  1. Client.sync_once() -> not advisable
  2. Search through state messages for event_type: "m.room.tombstone"
  3. Look for other ways like SubscribeToOwnUserReadReceiptsChanged.

alanpoon avatar Feb 27 '25 09:02 alanpoon

did you actually get tombstoned rooms to be marked as tombstoned according to the SDK? I never got them to work; see #178.

Even this Matrix SDK PR did not help: https://github.com/matrix-org/matrix-rust-sdk/pull/4211

I'm hoping that maybe an upgrade to the latest version of the SDK might help.... but I'm not confident.

kevinaboos avatar Feb 28 '25 08:02 kevinaboos