project-robius
Add Context Menu to messages and options menu on hover
- When right clicking a message or pushing on mobile, show context menu with reply button
- When hovering, show floating menu with reply button and a meatball menu button that opens the context menu mentioned above.
element example:
discord example:
Note:
We will wait until we have support for making overlay stuff inside makepad itself. This is being worked on rn.
Excellent, thanks for adding this to-do item! I'll add it to the new Robrix project tracker.
Once https://github.com/makepad/makepad/pull/530 gets merged, we can begin working on this.
Hello! The makepad PR was merged. Is anyone working on this already? If not, I'd like to work on this! The best place to start would be to first decide what exactly the context menu should show, given the current functionality that Robrix offers!
Hello! The makepad PR was merged. Is anyone working on this already? If not, I'd like to work on this! The best place to start would be to first decide what exactly the context menu should show, given the current functionality that Robrix offers!
AFAIK no one is working on it yet. Some things that would immediately be beneficial to have in the context menu are:
- Event ID (for debugging)
- quick reactions (this may be hard to implement since Makepad still doesn't support rendering emoji yet)
- reply
- view event source JSON, which looks like this in Element
Other features in the future would be "reply in thread", but we don't yet support threads so there's no point showing it in a context menu yet.
AFAIK no one is working on it yet. Some things that would immediately be beneficial to have in the context menu are:
- Event ID (for debugging)
- quick reactions (this may be hard to implement since Makepad still doesn't support rendering emoji yet)
- reply
- view event source JSON, which looks like this in Element
Other features in the future would be "reply in thread", but we don't yet support threads so there's no point showing it in a context menu yet.
Gotcha! Starting work on this. Quick reactions could for now be done using stringified emojis?
Another thing is that quick reactions are unique to the user. As in, the most used reactions by the user are shown in the example from Discord. How exactly do we go about implementing that?
Hello @kevinaboos! Would you like me to proceed with trying to work on this issue? If so, do you have any further advice I should keep in mind regarding this, considering makepad has been undergoing many changes recently?
You're more than welcome to, but I would note that this is potentially a very difficult issue that requires intimate knowledge of makepad internals. I'm not sure of the level of support for context menus at the moment; I know something exists but I haven't looked into it myself yet.
You're more than welcome to, but I would note that this is potentially a very difficult issue that requires intimate knowledge of makepad internals. I'm not sure of the level of support for context menus at the moment; I know something exists but I haven't looked into it myself yet.
Ah I see! I'll try to wrap my head around this and see if I can come up with something!
You're more than welcome to, but I would note that this is potentially a very difficult issue that requires intimate knowledge of makepad internals. I'm not sure of the level of support for context menus at the moment; I know something exists but I haven't looked into it myself yet.
Ah I see! I'll try to wrap my head around this and see if I can come up with something!
@smarizvi110 just FYI, we may have underestimated the difficulty of this, as it requires a decent amount of Makepad expertise. Another contributor to Makepad has just volunteered to help us address this issue, so you may want to work on a different issue with a smaller scope.
You're more than welcome to, but I would note that this is potentially a very difficult issue that requires intimate knowledge of makepad internals. I'm not sure of the level of support for context menus at the moment; I know something exists but I haven't looked into it myself yet.
Ah I see! I'll try to wrap my head around this and see if I can come up with something!
@smarizvi110 just FYI, we may have underestimated the difficulty of this, as it requires a decent amount of Makepad expertise. Another contributor to Makepad has just volunteered to help us address this issue, so you may want to work on a different issue with a smaller scope.
Gotcha! Thank you for the early heads up! If you have any particular issues you recommend I should look at, I'd be grateful to know about those too!