codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

Dynamic notebooks sync workflow

Open ChristianZaccaria opened this issue 1 year ago • 3 comments

Issue link

Related Jira: https://issues.redhat.com/browse/RHOAIENG-14201 Jira: https://issues.redhat.com/browse/RHOAIENG-14203

What changes have been made

With this change, we can dispatch the notebooks sync workflow by also providing the specific python version and target branch name, i.e., release-2024a for Notebooks with py3.9.

Verification steps

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Manual tests
    • [ ] Testing is not required for this change

ChristianZaccaria avatar Oct 09 '24 13:10 ChristianZaccaria

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.99%. Comparing base (b90d5d6) to head (026a326). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files          36       36           
  Lines        2364     2364           
=======================================
  Hits         2222     2222           
  Misses        142      142           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 09 '24 13:10 codecov[bot]

/hold testing workflow: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11256244629/job/31297661132

ChristianZaccaria avatar Oct 09 '24 13:10 ChristianZaccaria

@Bobbins228 yes, I was testing for py3.11. I added the workflow run and PR generated for that now. Thanks!

ChristianZaccaria avatar Oct 14 '24 11:10 ChristianZaccaria

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 14 '24 13:10 openshift-ci[bot]