codeflare-sdk
codeflare-sdk copied to clipboard
move current namespace logic to config
What changes have been made
I was running into some issues testing locally without specifying a namespace. I realized we could default early and make the error much clearer
Verification steps
Use the codeflare_sdk in a jupyter nb locally and don't specify namespace in your cluster configuration
Checks
- [ ] I've made sure the tests are passing.
- Testing Strategy
- [ ] Unit tests
- [ ] Manual tests
- [ ] Testing is not required for this change
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from kpostoffice. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Perhaps kube_api_helpers doesnt work as there could be a circular import. What would you think of a utils file in the utils module for helper functions like this?
I say this because as we add more modules e.g. KFT Training Client we would probably prefer common functions like this to live there? WDYT?
I'll take a look at finding a better place for this. A util file definitely makes more sense than auth.py
Closing this as the namespace logic was moved to k8s_utils in another PR 🙏