codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

Updating training script in basic_interactive notebook

Open Fiona-Waters opened this issue 1 year ago • 1 comments

Issue link

RHOAIENG-6475

What changes have been made

When running GPU utilising workloads using the basic_interactive demo notebook I encountered a lot of errors while running the training script provided in the notebook. As it was added more than a year ago and may be out of date I have updated the notebook to use the recently added mnist_fashion.py training script instead.

Verification steps

  • Install RHOAI with the CodeFlare components set to Managed
  • Ensure that your cluster has GPU nodes as required.
  • Within a data science project workbench clone this branch
git clone https://github.com/Fiona-Waters/codeflare-sdk.git -b udpate-notebook-script
  • Run the basic_interactive notebook and ensure that it works as expected.

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [X] Manual tests
    • [ ] Testing is not required for this change

Fiona-Waters avatar May 23 '24 16:05 Fiona-Waters

/retest

astefanutti avatar Jun 19 '24 09:06 astefanutti

This PR just needs a rebase and it should pass the e2e test

Bobbins228 avatar Jun 19 '24 14:06 Bobbins228

/lgtm

astefanutti avatar Jun 19 '24 15:06 astefanutti

/approve

astefanutti avatar Jun 19 '24 15:06 astefanutti

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Bobbins228,astefanutti]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 19 '24 15:06 openshift-ci[bot]