codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

Add warning if Kueue CRDs not installed on cluster

Open oksanabaza opened this issue 1 year ago • 2 comments

Issue link

RHOAIENG-6294

What changes have been made

A warning has been added to the ClusterConfiguration cell to inform users if Kueue CRDs are not installed on the cluster and local_queue is not provided. In this scenario, users will receive informative logs indicating that the absence of CRDs may result in missing functionality.

Verification steps

Uninstall Kueue and delete any CustomResourceDefinitions (CRDs) that exist (filter for CustomResourceDefinition in resources and select LocalQueue in the name). Clone this branch into Jupyter Notebook, attempt to create a Ray cluster. In the ClusterConfiguration cell, comment out the local_queue="local-queue-name" line. When you run it, you should receive a message indicating that Kueue is not installed or won't be used. The absence of CRDs may result in missing functionality.

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [x] Manual tests
    • [ ] Testing is not required for this change

oksanabaza avatar May 10 '24 15:05 oksanabaza

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fiona-waters for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 10 '24 15:05 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar May 24 '24 22:05 openshift-merge-robot

Closing this pull request as the previous changes cover this issue

oksanabaza avatar Jun 28 '24 12:06 oksanabaza