codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

simplify function calls and add option for custom resources

Open KPostOffice opened this issue 1 year ago • 2 comments

Issue link

What changes have been made

I changed some of the huge function calls that were getting out of hand to take a reference to the cluster object. It might be worthwhile to make these into class methods at a future date

I have also added the ability for the user to specify custom resource requirements for Ray

Verification steps

Checks

  • [ ] I've made sure the tests are passing.
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Manual tests
    • [ ] Testing is not required for this change

KPostOffice avatar May 09 '24 20:05 KPostOffice

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jul 09 '24 17:07 openshift-ci[bot]