codeflare-sdk icon indicating copy to clipboard operation
codeflare-sdk copied to clipboard

Cli update

Open carsonmh opened this issue 2 years ago • 2 comments

Issue link

closes #284

What changes have been made

Codeflare CLI, adding a command line interface that allows similar functionality to the Codeflare SDK. Changes to SDK include:

  • creating Cluster object from yaml function
  • refactored some parts of the Codeflare SDK
  • allow app wrapper creation to be optional

Verification steps

-codeflare --help to see a list of all commands, run each one to test

  • You can run unit tests with pytest

Checks

  • [x] I've made sure the tests are passing.
  • Testing Strategy
    • [x] Unit tests
    • [x] Manual tests
    • [ ] Testing is not required for this change

carsonmh avatar Aug 11 '23 21:08 carsonmh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 11 '23 21:08 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Aug 23 '23 19:08 openshift-merge-robot