connectedhomeip icon indicating copy to clipboard operation
connectedhomeip copied to clipboard

Published 20 hours ago • verified publisher icon project-chip

Add Attribute and Command Conformance to ZAP Template XMLs

Open ethanzhouyc opened this issue 1 year ago • 9 comments

  • Added conformance details for attributes and commands in ZAP template XMLs from the new XML version. The added XML data is necessary for the functionality of the Feature Page project.

  • This commit only updates XMLs with initials from A to C to ease the review process. Remaining XML changes will be addressed in subsequent PRs.

  • Removed the Feature bitmap in content-launch-cluster.xml and replaced it with features represented by the <Feature> tag. The value in original Feature bitmap is wrong: the feature masks should be 0x01, 0x02, 0x04, 0x08, 0x10, but in the XML it was 0x01, 0x02, 0x03, 0x04, 0x05. Consequently, after the update, the CI job would fail but the change is actually correct. Should consider correcting this bitmap checking in CI. See job failure details

  • Corrected the OnOff feature code in matter-devices.xml

ethanzhouyc avatar Oct 01 '24 20:10 ethanzhouyc

Review changes with SemanticDiff.

semanticdiff-com[bot] avatar Oct 01 '24 20:10 semanticdiff-com[bot]

PR #35865: Size comparison from 353f4dfc17427557b2fb0a96b1d34c6fad6c59ab to 07fa1981986508626c730622a35ef05f28be023d

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 353f4dfc 07fa1981 change % change
bl602 lighting-app bl602 FLASH 1281066 1281066 0 0.0
RAM 95848 95848 0 0.0
bl602+mfd FLASH 1295188 1295188 0 0.0
RAM 95992 95992 0 0.0
bl602+rpc FLASH 1321272 1321272 0 0.0
RAM 104272 104272 0 0.0
bl702 lighting-app bl702 FLASH 945156 945156 0 0.0
RAM 15145 15145 0 0.0
bl702+mfd FLASH 947556 947556 0 0.0
RAM 15305 15305 0 0.0
bl702+rpc FLASH 1040720 1040720 0 0.0
RAM 24173 24173 0 0.0
bl706-eth FLASH 647322 647322 0 0.0
RAM 25233 25233 0 0.0
bl706-wifi FLASH 895200 895200 0 0.0
RAM 14477 14477 0 0.0
bl702l lighting-app bl702l FLASH 961816 961816 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 964438 964438 0 0.0
RAM 16964 16964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829492 829492 0 0.0
RAM 123300 123300 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814568 814568 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761116 761116 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745352 745352 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616826 616826 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656946 656946 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678461 678461 0 0.0
RAM 78516 78516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698313 698313 0 0.0
RAM 81148 81148 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698313 698313 0 0.0
RAM 81148 81148 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655249 655249 0 0.0
RAM 73584 73584 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614533 614533 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634169 634169 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634169 634169 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633837 633837 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653553 653553 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653553 653553 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609149 609149 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629009 629009 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629009 629009 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933980 933980 0 0.0
RAM 135884 135884 0 0.0
lock-app BRD2605a FLASH 741824 741816 -8 -0.0
RAM 230240 230240 0 0.0
BRD4338a FLASH 742472 742464 -8 -0.0
RAM 230272 230272 0 0.0
window-app BRD4187C FLASH 1017128 1017120 -8 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1538296 1538296 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548738 1548738 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2775893 2775893 0 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6079322 6079322 0 0.0
RAM 507392 507392 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5413186 5413186 0 0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4746604 4746604 0 0.0
RAM 218320 218320 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12557306 12557306 0 0.0
RAM 555282 555282 0 0.0
chip-tool-ipv6only arm64 unknown 20520 20520 0 0.0
FLASH 11213904 11213904 0 0.0
RAM 605512 605512 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 10918461 10918461 0 0.0
RAM 554298 554298 0 0.0
fabric-bridge-app debug unknown 4640 4640 0 0.0
FLASH 4569618 4569618 0 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5687473 5687473 0 0.0
RAM 228584 228584 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4796026 4796026 0 0.0
RAM 204392 204392 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4425558 4425558 0 0.0
RAM 198128 198128 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4564406 4564406 0 0.0
RAM 202696 202696 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3105965 3105965 0 0.0
RAM 159216 159216 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4314592 4314592 0 0.0
RAM 242816 242816 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6023429 6023429 0 0.0
RAM 580944 580944 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10751341 10751341 0 0.0
RAM 643024 643024 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914120 914120 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884952 884952 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847540 847540 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581880 581880 0 0.0
RAM 70784 70784 0 0.0
k32w1+release FLASH 596608 596608 0 0.0
RAM 63008 63008 0 0.0
mcxw71+release FLASH 596368 596368 0 0.0
RAM 63008 63008 0 0.0
light k32w0+release FLASH 618468 618468 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682568 682568 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682584 682584 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 704944 704944 0 0.0
RAM 67148 67148 0 0.0
mcxw71+release FLASH 704968 704968 0 0.0
RAM 67148 67148 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646012 1646012 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552052 1552052 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467804 1467804 0 0.0
RAM 200696 200696 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464596 1464596 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660216 660216 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618236 618236 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481768 481768 0 0.0
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620608 620608 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687804 687804 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780796 780796 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680706 680706 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620372 620372 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708312 708312 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625486 625486 0 0.0
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811246 811246 0 0.0
RAM 98948 98948 0 0.0
lock-app-dfu tlsr9528a FLASH 656256 656256 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696682 696682 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634004 634004 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611194 611194 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467862 467862 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627502 627502 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653330 653330 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 637926 637926 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524068 524068 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725388 1725388 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10348 10348 0 0.0
FLASH 17361514 17361514 0 0.0
RAM 7564348 7564348 0 0.0

github-actions[bot] avatar Oct 01 '24 21:10 github-actions[bot]

@ethanzhouyc could you describe the following:

  • were these manually added or by a robot? I would trust it more if these were script/automated added. If these require manual adding, maybe we can work with @hasty to add it to Alchemy instead
  • is this supported by zap? Any links to documentation on how this will be used? This will help people looking at logs in the future

For the ZAP failure, you need to zap-regen if you change things that codegen depends on.

andy31415 avatar Oct 02 '24 13:10 andy31415

  • These were manually added, but based on automated generated XMLs from data_model/master folder.

  • ZAP support is not available yet, but I am working on the Feature Page project and have a pending PR that will enable this. I will follow up with documentation once it’s ready.

  • To fix the ZAP failure, I will create a separate PR to correct the zap-regen

ethanzhouyc avatar Oct 02 '24 15:10 ethanzhouyc

  • These were manually added, but based on automated generated XMLs from data_model/master folder.

This is a one-line change to alchemy, if we're ok with adding this to the ZAP XML; would be a lot easier than manually copying.

hasty avatar Oct 02 '24 17:10 hasty

And presumably we'd want to do it for events as well?

hasty avatar Oct 02 '24 17:10 hasty

@hasty If we could automate the process, it would be great and let's do it! Can you help adapt Alchemy to my automated generation needs? Once it's ready, can you give instructions on how to use the new feature? Thank you!

ethanzhouyc avatar Oct 02 '24 18:10 ethanzhouyc

And presumably we'd want to do it for events as well?

Yes we should add conformance for events too

ethanzhouyc avatar Oct 02 '24 19:10 ethanzhouyc

OK, version 0.8.2 now supports a conformanceXML flag on zap generation, with support for attributes, commands and events: https://github.com/project-chip/alchemy/releases/tag/v0.8.2

alchemy zap --specRoot=<path to connectedhomeip-spec> --sdkRoot=<path to connectedhomeip> --attribute="in-progress" --conformanceXML=true

hasty avatar Oct 03 '24 00:10 hasty