Limnoria icon indicating copy to clipboard operation
Limnoria copied to clipboard

OEmbed support

Open progval opened this issue 7 years ago • 5 comments
trafficstars

as a new plugin / extension of Web?

progval avatar Dec 23 '17 19:12 progval

This was mentioned briefly on IRC last week. I'm not sure how you want to add this to the web plugin. Here is my idea on how to add it: https://github.com/lodriguez/Limnoria/commit/b282498080bb23dff39d3ec88b9c03e2e552ddad

lodriguez avatar Nov 20 '24 16:11 lodriguez

You don't need to fetch the list of providers; the title snarfer already downloads the start of the page so it can look for <link> tags

progval avatar Nov 20 '24 17:11 progval

That was my first Idea, but discovery sucks. Many sites don't have it in the link tags, so we would start adding workarounds for sites like reddit again.

lodriguez avatar Nov 20 '24 17:11 lodriguez

Alright, it should support both then. Open a PR with support for both registry and discovery, configurability, and a couple of tests and we'll work on that. Also, the registry should be downloaded when it is needed for the first time (and in a thread) instead of in the __init__() in order to not make the bot hang while it's downloading.

progval avatar Nov 20 '24 17:11 progval

Fair enough, that's why I commended here first.

lodriguez avatar Nov 20 '24 17:11 lodriguez