jekyll
jekyll copied to clipboard
Publish fr/lecons/normaliser-donnees-textuelles-python
Preparing files for publication.
Closes #3349
Checklist
- [x] Assign yourself in the "Assignees" menu
- [x] Add the appropriate "Label"
- [x] If this PR closes an Issue, add the phrase
Closes #ISSUENUMBERto your summary above - [x] Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
- [x] Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
- [x] Assign at least one individual or team to "Reviewers"
- ~[ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.~
Dear Marie @marie-flesch.
I’ve staged normaliser-donnees-textuelles-python for publication. You can read it through in Preview and let me know if you note anything which you'd like to adjust.
If you're happy, we can publish it tomorrow morning when our colleagues at Sussex will be around to activate our DOI, and then we can launch the promotions on social media.
--
Thank you for your patience today (there have been multiple broken links in our path!), A.
Hello @marie-flesch, @matgille and @anisa-hawes,
I have prepared some updates to the lesson, to help readers work around the issue with the Old Bailey Online link. Could you take a look at my edits in the preview, and let me know what you think?
One thing I did was create an asset folder for the lesson, and add the HTML file directly to it. You'll see that I provide the link to this file in the lesson, but I notice it's not a 'direct download' link (it opens the file in another tab). @anisa-hawes might be able to clarify whether the link will turn into a 'direct download' when the lesson is live?
Looking forward to your feedback! ✨
Thank you for your patience, @matgille.
Are you able to confirm that you're happy with how the lesson reads in the Preview?: https://deploy-preview-3350--ph-preview.netlify.app/fr/lecons/normaliser-donnees-textuelles-python#convertir-en-minuscules.
I think we are agreed! But please let us know, and we will publish this (quietly).
Hi @anisa-hawes, hi @charlottejmc and @marie-flesch , I've changed the code and the warning a little bit. I'll test it with the preview this week end or monday in the morning but I think it will work:
- I've changed the code to replace the url
- the method to read the file is the original one (with urllib)
- I've adapted the warning a bit.
We are going to finish this ! As for me I'm not in a hurry at all, I prefer to have a functional lesson even if it takes some days to agree on what we want to publish.
Enjoy your week end
Matthias
Merci, Matthias @matgille!
Your adjustments read well to me. We will wait to hear from you next week, and we can publish when you are satisfied with everything.
Very best, Anisa
Hi @anisa-hawes,
Thanks for your feedback. I've made some minor changes in the code, I think we can merge the branch now. We'll have to check the link to the archived html page is correct when the merge is done but it should work properly.
@marie-flesch can you review the changes ?
Best
Matthias
Hi @charlottejmc,
/assets/normaliser-donnees-textuelles-python/obo-t17800628-33.html is on the branch we are going to merge. I've looked at other html pages in the assets, the following URL for instance: https://programminghistorian.org/assets/fetch-and-parse-data-with-openrefine/pg1105.html and it works. I think the OBO html page should work too !
Best
Matthias