redis4cats icon indicating copy to clipboard operation
redis4cats copied to clipboard

Adding pooling support with keypool.

Open BusyByte opened this issue 2 years ago • 2 comments

Closes: https://github.com/profunktor/redis4cats/issues/822

BusyByte avatar Dec 08 '23 16:12 BusyByte

@gvolpe and @decoursin can you please review?

BusyByte avatar Dec 08 '23 17:12 BusyByte

Sorry, I'm not going to be able to review, it's a little bit beyond my skill level to grasp the codebase in a reasonable time to give a qualified review. I do appreciate your potential contributions though.

decoursin avatar Dec 08 '23 17:12 decoursin

@BusyByte do you need a help with fixes?

andriibutko avatar Mar 11 '24 14:03 andriibutko

@gvolpe @yourzbuddha just getting back to this. kind of fell off my radar for a bit. I can see if I can get a chance to look at it today.

BusyByte avatar Mar 21 '24 12:03 BusyByte

@BusyByte I can assist.

andriibutko avatar Mar 21 '24 13:03 andriibutko

@gvolpe let me know if you need any additional changes from me

BusyByte avatar Mar 21 '24 14:03 BusyByte

@BusyByte thanks!

I'm not sure if adding a private function to MkRedis is actually backwards compatible.

Yeah I've no idea either. Ideally, we should use MiMa, if anyone volunteers to do the work :)

In the meantime, it is clarified in the README file:

The API is quite stable and heavily used in production. However, binary compatibility is not guaranteed across versions for now.

gvolpe avatar Mar 21 '24 15:03 gvolpe

@yourzbuddha thanks for offering to help, I had time today so just knocked it out

BusyByte avatar Mar 21 '24 15:03 BusyByte

Thanks guys :)

decoursin avatar Mar 21 '24 16:03 decoursin