Remove second call of _updateWindowSize()

Open bensgilbert opened this issue 6 months ago • 3 comments

https://github.com/processing/p5.js/commit/173e09552c698cb2ec5e107d42280edfc9c75995 in https://github.com/processing/p5.js/pull/7785 accidently added a second call to this._updateWindowSize(); during initialisation this function I added only needs to be called once

Trivial fix

May 25 '25 23:05 bensgilbert

welp, the test action fails but not sure why as stated functionality hasn't been touched

May 25 '25 23:05 bensgilbert

Hi @bensgilbert are the same tests failing if you remove the second call to _updateWindowSize rather than the first one? EDIT: It's failing on the branch too, so no need to do anything here, looking into it!

May 26 '25 06:05 ksen0

@ksen0 just revisiting this

Jun 07 '25 16:06 bensgilbert

@all-contributors please add @bensgilbert for code

Jun 19 '25 19:06 davepagurek

@davepagurek

I've put up a pull request to add @bensgilbert! :tada:

Jun 19 '25 19:06 allcontributors[bot]