p5.js
p5.js copied to clipboard
FES should fetch translations within the same minor version
trafficstars
Increasing access
FES internationalization improvement to match 1.x/2.x difference
Most appropriate sub-area of p5.js?
- [ ] Accessibility
- [ ] Color
- [ ] Core/Environment/Rendering
- [ ] Data
- [ ] DOM
- [ ] Events
- [ ] Image
- [ ] IO
- [ ] Math
- [ ] Typography
- [ ] Utilities
- [ ] WebGL
- [x] Build process
- [ ] Unit testing
- [x] Internationalization
- [ ] Friendly errors
- [ ] Other (specify if possible)
Feature enhancement details
Currently, FES fetches translations using latest: https://github.com/processing/p5.js/blob/5f0fcfac9d03a5ec2fee271a98fa1d1edb70ec68/src/core/internationalization.js#L153
Which results in a. 1.x sketch getting 2.x FES translations, which may be inaccurate. Should fetch within the minor version, but latest patch, for example: if the sketch is 1.11.1, it should get language for 1.11.7 (or whatever is latest)
This should be patched first in 1.x, and then a matching 2.x