p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Split contents of dom.js among four(4) files

Open SilasVM opened this issue 1 year ago • 0 comments

Resolves #7308

Changes:

Distributed the code within dom.js, across dom.js, p5.Element.js, p5.MediaElements.js, and p5.File.js. Specific details of the split are detailed in Proposal #7308.

I've had trouble running the npm test command. I was unable to run it on a clean branch, so I don't think this is a direct indication of any issues with my changes. Please let me know if there's an alternate form of testing for this branch

I was also unsure of how to modify lines 13-19 of each file.

  • Should dom.js import each new file?
  • Do lines 13-16 need modification?

Screenshots of the change:

image

PR Checklist

Please let me know your thoughts @limzykenneth.

SilasVM avatar Oct 17 '24 01:10 SilasVM