p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Added example and Unit tests for ClampToZero method on p5.Vector.

Open Forchapeatl opened this issue 1 year ago • 5 comments

Resolves #6750

Changes:

Screenshots of the change:

PR Checklist

Forchapeatl avatar Sep 01 '24 03:09 Forchapeatl

Than you for the review @ashish1729 . I have made the updated changes, please have a look at my PR.

Forchapeatl avatar Sep 05 '24 08:09 Forchapeatl

thank you for fixing all these, although I am not a maintainer, I don't think I can/should approve changes.

ashish1729 avatar Sep 05 '24 08:09 ashish1729

No worries @ashish1729 , I really needed someone to put me on track. Thank you.

Forchapeatl avatar Sep 05 '24 08:09 Forchapeatl

Keep up the great work. Some thoughts, let me know what you feel. :)

Here how it shows when you run grunt yui:dev in your code-editor, you need to open the developer tools in your browser to see the log values.

image

This could be resolved by two solution.

  1. If you write the code just as a function, for ex:
```js
your sketch....```

and by writing some description for eg; Here's the after result (maybe in your words):

```js
before : values
after : values```
  1. The second option is to use text() function and can write the log values into the canvas by making a canvas of 100X100.

Let me know what you think by these thoughts :)

perminder-17 avatar Sep 19 '24 19:09 perminder-17

thanks @perminder-17 , I will work on this over the weekend

Forchapeatl avatar Sep 19 '24 20:09 Forchapeatl