p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Published 20 hours ago • verified publisher icon processing

Added tests for user/pages folder

Open Rajnish2105 opened this issue 11 months ago • 2 comments

Fixes #2923

Changes: SignupView unit test ResetPasswordView unit test NewPassword unit test LoginView unit test EmailVerificationView unit test AccountView unit test-9cases Dashboard unit test CollectionsView unit test

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

Rajnish2105 avatar Dec 24 '24 19:12 Rajnish2105

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Dec 24 '24 19:12 welcome[bot]

This looks to be a nice start. I think there needs to be more discussion on the testing strategy and what the goals are. Addressing questions like:

  1. What kind of unit tests will increase your confidence that the component is functional? testing existence of elements and its count is nice, are there any kind of tests depending on the component that might help with testing?
  2. Using data id locators is great, noticed you have used it in some places. When should is it preferable over role/label text locators?

And other questions would help guide the implementation better. (Not a maintainer, just my thoughts). any feedback @raclim ?

dsaw avatar Mar 08 '25 06:03 dsaw