p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Icon Alignment Issue in Password Field – Adjust Eye Icon Vertical Centering

Open BamaCharanChhandogi opened this issue 1 year ago • 3 comments

Increasing Access

Design Improvements.

Feature enhancement details

In the login form's password field, the visibility toggle (eye icon) is not properly vertically centered. This causes a slight misalignment, affecting the overall visual layout of the password input field.

Steps to Reproduce:

  • Navigate to the login form.
  • Inspect the password field.
  • Observe that the eye icon is not vertically aligned in the middle of the input field.

Expected Behavior:

image

Actual Behavior:

Screenshot 2024-09-25 015048

BamaCharanChhandogi avatar Sep 24 '24 21:09 BamaCharanChhandogi

Thanks for raising this issue!

The current behavior was intentionally changed to center the eye icon within the input field. If we implement the suggested updates as shown in the Expected Behavior image, the eye icon becomes a little higher from the center.

Maybe instead of changing the positioning of the icon, it might be worth looking into changing the icon's size or looking for a different graphic?

raclim avatar Sep 26 '24 15:09 raclim

Thanks for raising this issue!

The current behavior was intentionally changed to center the eye icon within the input field. If we implement the suggested updates as shown in the Expected Behavior image, the eye icon becomes a little higher from the center.

Maybe instead of changing the positioning of the icon, it might be worth looking into changing the icon's size or looking for a different graphic?

Have you checked #3242 PR?

BamaCharanChhandogi avatar Sep 26 '24 15:09 BamaCharanChhandogi

Yes, I took a look at it! I feel that your PR faces the dilemma that I was touching on—although the eye icon is technically aligned, visually it appears a little off center and is more skewed towards the top of the input field.

Screenshot 2024-09-26 at 11 50 33 AM

I personally prefer keeping the CSS for the eye icon as is for now, but I'm open to suggestions of other ways of changing it.

raclim avatar Sep 26 '24 15:09 raclim