p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Fix: Logout error modal popping up on downloading other users' sketch…

Open NishantBansal2003 opened this issue 1 year ago • 2 comments

Fixes #3053

Changes: This update improves the 'downloadSketch' function by adding validation checks. It ensures that projects are only saved when the logged-in user owns them, reducing unnecessary API requests and enhancing the user experience.

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #3053

NishantBansal2003 avatar Mar 28 '24 07:03 NishantBansal2003

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Mar 28 '24 07:03 welcome[bot]

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-083ad3c08f

release-com[bot] avatar Mar 28 '24 07:03 release-com[bot]

Thanks for your work on this! This ultimately ended up getting addressed by #3116, so I'm going to close this PR. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

raclim avatar Jun 05 '24 18:06 raclim