p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Fix : [#2986] Add ref callback

Open Ri-Sharma opened this issue 1 year ago • 1 comments

Fixes #2986

Changes:

  1. Added ref callback function to resolve the issue

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number.

Ri-Sharma avatar Feb 04 '24 18:02 Ri-Sharma

If we have this problem in the CollectionListRow then odds are that we also have it in the SketchListRow. Those components are very similar and I don't like the current system where we have to make analogous changes in both places when we see an issue like this.

The SketchListRow is working fine and the problem only exists with the collections. I think this is because the SketchListRow uses class components where as the CollectionListRow uses funtional component and for some reason same logic is working for the classes but not for the functions.

Ri-Sharma avatar Feb 05 '24 07:02 Ri-Sharma