p5.js-web-editor
p5.js-web-editor copied to clipboard
processing
In `About` modal position of "Contribute" and "Report a bug" is not consistent
p5.js version
2.8.0
What is your operating system?
Mac OS
Web browser and version
Chrome and 117.0.5938.132
Actual Behavior
In About modal position of "Contribute" and "Report a bug" is not consistent
Expected Behavior
In About modal position of "Contribute" and "Report a bug" should be consistent
Steps to reproduce
Steps:
- Open the editor
- Go to Help dropdown
- Click on about
- Notice at the end of modal, position of contribute and report a bug is not consistent
Good catch. We recently added some responsive breakpoints to that component which are better than nothing but not perfect. I bet if you look through the git history of the _about.scss you can see what we used to have. I think there was previously a large left margin on the footer section to align it? We would want to put that back in, but only on large/desktop screens.
Hello, is the expected design something like this. Aligned vertically with above columns
@PiyushChandra17 hello, is this the desired output, the Contribute and report links alligned with the two existing columns? If yes, I would like to create a pr.
@lindapaiste As I can see from history there was a larger left padding at the ".about__footer" so putting that back it would look something like this. Is this what you wanted it to be ?
And also "New to p5.js?" and "Resources" which are column title are also not align to column list, so is that ok then ignore it, I just removed there left padding it looks better for me, if you can comment on them as well.
Greetings, is this the desired result? If so, let me know so I can make a PR.
If not, please specify how the content should be styled.
@PiyushThapaa but if you have already done it you can make the pr
no i haven't can you please help me i enable to host the server do you how to host the server locally after cloning
you can simply use docker setup to start a localhost ...go through the contributing docs
@PiyushChandra17 I am going to raise pr for this particular issue soon ...but firstly let me know if you are working on this issue.
I can host the application locally using docker but when I make changes in the code it is not getting refreshed in the code. So I have to build a new image every time there is something I am doing wrong. Kindly help me with this.
