p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Moved Search bar to be a functional component

Open Karanpal97 opened this issue 2 years ago • 2 comments

Fixes #2358

Changes:

Ref #2358

Description: The issue was that the search bar was not a functional component, leading to performance issues. I refactored the code to move the search bar into a functional component, improving the performance and maintainability of the code

Changes Made: Moved the search bar to be a functional component.

Verification: I have verified that this pull request:

  • [✓] has no linting errors (npm run lint)
  • [✓] has no test errors (npm run test)
  • [✓] is from a uniquely-named feature branch and is up to date with the karan/searchBar branch.
  • [✓] is descriptively named and links to an issue number, i.e. Ref #2358

Karanpal97 avatar Oct 17 '23 13:10 Karanpal97

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Oct 17 '23 13:10 welcome[bot]

hey what will be next process for merging this pull Request

On Thu, Oct 19, 2023 at 8:25 PM PiyushChandra17 @.***> wrote:

@.**** approved this pull request.

Looks good to me

— Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-web-editor/pull/2509#pullrequestreview-1687976391, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4YNWZ3AXUTGPMORDHDYYGDYAE5NHAVCNFSM6AAAAAA6DZ7QQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBXHE3TMMZZGE . You are receiving this because you authored the thread.Message ID: @.***>

Karanpal97 avatar Oct 20 '23 08:10 Karanpal97

Thanks for your work on this! This issue ultimately was addressed by PR #2431, so I'm going to close this one. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

raclim avatar Jun 13 '24 16:06 raclim