p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

iframe background to white

Open akshatnema opened this issue 3 years ago • 3 comments

Fixes #1852

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

Preview of Changes

In Dark Mode Screenshot from 2022-01-04 21-23-25

In Contrast Mode Screenshot from 2022-01-04 21-23-41

Hey @catarak, I have made changes to make the default background of iframe to white. Kindly review the PR and do let me know if certain changes are to be made.

akshatnema avatar Jan 04 '22 16:01 akshatnema

Release Environments

This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.

:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-b9d370babe

release-com[bot] avatar Jan 04 '22 16:01 release-com[bot]

@limzykenneth @catarak Any updates on this PR?

akshatnema avatar Jan 10 '22 12:01 akshatnema

@akshatnema I'm not directly involved with the development of the web editor. It can take time for us to review or find time to review a PR, so do be patient with this. Thanks.

limzykenneth avatar Jan 10 '22 13:01 limzykenneth

Hi @akshatnema, thanks for working on this!

So far it's looking good but I think in it's current state, it still holds a potential issue where the entire preview pane is white even when no sketch is running, which can result in a confusing user experience. nsmarino's comment highlights an alternative solution. If it sounds good, you can give it a go or try out something new! :)

raclim avatar Feb 08 '23 20:02 raclim

Hi! I'm going to close this PR for now, but please feel free to reopen this or create a new one if you'd like to continue working on this issue, thanks! :)

raclim avatar Feb 16 '23 16:02 raclim