p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Published 20 hours ago • verified publisher icon processing

Korean Translation of Web Editor

Open yinhwa opened this issue 5 years ago • 7 comments

Currently in progress with @kangashley & @yinhwa

Hi @catarak, @ghalestrilo ! I'm trying to add Korean translation to the web editor to increase the editor's lingual accessibility to Korean speakers. My particular concern is on some dozens of older adults in Korea that I'll be having p5.js workshop with on November, but it certainly will be helpful for the language group in general both in and out the country.

I have checked in with @ghalestrilo if there'd be any conflicts on the mobile UI if I add new translation, and Thales's told me it will work automatically :) I've also noticed that [Spanish translation] was successfully added a couple months ago!🎉

And yet, I would like to ask if it will be alright for me to start working on it by now; and if adding translation was part of the maintenance plan. If everything's fine, I'm planning to have it done before the Week 2 of November, since I'm having the workshop on Week 3-4 and afterwards.

Please let me know your opinion! Thank you :)

Nature of issue?

  • Existing feature enhancement
  • New feature request

Feature enhancement details:

  • Add Korean translation of log in/sign up; menus; (+examples if possible)

New feature details:

  • Add "Korean" button on the top right corner

yinhwa avatar Oct 15 '20 00:10 yinhwa

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

welcome[bot] avatar Oct 15 '20 00:10 welcome[bot]

Hey @yinhwa! I'm super excited you want to work on this. Now that @oruburos did the first translation, the new ones should be simpler. He made a translation guide which should help you. Let me know if you have any questions! Also, feel free to open multiple pull requests to complete this, as now that there are releases (like v1.1.1, etc), things that are merged into develop are not immediately merged to production.

catarak avatar Oct 15 '20 18:10 catarak

@catarak thank you Cassie!!! :) wish my best luck with the new releases🎇🎉 p5 web editor rox yay!

yinhwa avatar Oct 16 '20 06:10 yinhwa

Hey @yinhwa and @catarak , good to see people working on this. Also, please check #1638 . Good luck.

oruburos avatar Oct 18 '20 02:10 oruburos

Thanks @oruburos for letting me know and your guides on Koji's Issue 😁 Also excited for @koji 's Japanese translation!

yinhwa avatar Oct 18 '20 02:10 yinhwa

@yinhwa Actually, your issue helped me to start working on my issue! Thank you for opening this!

koji avatar Oct 18 '20 02:10 koji

@kangashley is joining this translation 🥰 yay

yinhwa avatar Oct 21 '20 06:10 yinhwa