p5.js-sound icon indicating copy to clipboard operation
p5.js-sound copied to clipboard

monosynth.triggerRelease() does not reach 0

Open therewasaguy opened this issue 7 years ago • 1 comments

MonoSynth is using Envelope's ramp method, which uses setTargetAtTime, and that never reaches the target value.

therewasaguy avatar Jun 26 '18 00:06 therewasaguy

@therewasaguy After going through this issue I think that directly passing the third parameter i.e 0 in the ramp method is causing problems. In my opinion, by initializing a new parameter such as a targetValue to 0 and passing it through the Envelope's ramp method so that it can reach the target of 0 will help in solving the above problem. I have opened a PR, implementing the same. Let me know if this fixes the issue. Thanks

parulpriyedarshani avatar May 01 '20 15:05 parulpriyedarshani