MiniDexed icon indicating copy to clipboard operation
MiniDexed copied to clipboard

Confirmation for Overwrite

Open probonopd opened this issue 7 months ago • 6 comments

Like for Delete; closes #856

probonopd avatar Apr 20 '25 17:04 probonopd

Build for testing: MiniDexed_2025-04-20-51bdf3d Use at your own risk.

github-actions[bot] avatar Apr 20 '25 17:04 github-actions[bot]

For consistency, could bOverwriteMode and bConfirmOverwrite be private members?

soyersoyer avatar Apr 20 '25 17:04 soyersoyer

Great point @soyersoyer. It should. Will change it once it is confirmed that functionality-wise this fulfills the requestor's requirement.

Hello @Octet-nl, would you like to test the build above? Thanks.

probonopd avatar Apr 20 '25 19:04 probonopd

It doesn't work.

I can save a new performance. It automatically uses the next available slot for the new performance. Overwriting doesn't work. Save - Overwrite - "Overwrite? the performance name is in the second line" after clicking to confirm, the UI crashes. The sound still works, but the controls freeze. No changes to the performance are saved either. Peter

Banana71 avatar Apr 20 '25 19:04 Banana71

Argh. Will need to dig deeper. Thanks for testing though (currently away from my hardware).

probonopd avatar Apr 20 '25 19:04 probonopd

Same for me. Back button still works and UI stays active. Voice functions still work, sound ok. Selecting Overwrite no longer works (does not show Overwrite? again). Performance is not saved.

Octet-nl avatar Apr 21 '25 07:04 Octet-nl