privacytools.io icon indicating copy to clipboard operation
privacytools.io copied to clipboard

Published 20 hours ago • verified publisher icon privacytools

Use cdn.privacytools.io for static resources

Open jonaharagon opened this issue 5 years ago • 4 comments

You'd have to build locally with JEKYLL_ENV=production bundle exec jekyll serve or JEKYLL_ENV=production bundle exec jekyll build to see the changes yourself, since the CDN URL should not be used in a development environment like Netlify

jonaharagon avatar May 27 '20 04:05 jonaharagon

Nice, could we also update the Readme build instructions to include this PR’s description? Helpful for future reference.

nitrohorse avatar May 27 '20 05:05 nitrohorse

Why would we need a CDN though?

blacklight447 avatar May 27 '20 12:05 blacklight447

could we also update the Readme build instructions to include this PR’s description?

We could, although it doesn't make sense to load from the CDN in development. Because if you add a new image or whatever to your local fork, the CDN won't display it obviously, it will only load assets on the webserver. So really you'd only set JEKYLL_ENV=production when building the live website, or if you just wanted to see the CDN in action for some reason (like you might with this specific PR). But otherwise I'm not sure it's particularly helpful information.

jonaharagon avatar May 29 '20 02:05 jonaharagon

Ah that makes sense, okay, I was mistaken; we can leave the Readme as-is.

nitrohorse avatar May 29 '20 22:05 nitrohorse