zkevm-circuits

zkevm-circuits copied to clipboard

Review usage of geth API calls

3

- Currently we're using the geth API `debug_traceBlockByHash` to get execution traces (with memory disabled, which we reconstruct on our side) - We're generating a trace of accessed data in...

ed255

Refactor PublicInput circuit with challenge API

3

andyguzmaneth

GH Actions: Integration tests workflow not working as expected

1

ntampakas

- [ ] 0x01 ecRecover - [x] spec https://github.com/privacy-scaling-explorations/zkevm-specs/issues/318 - [x] circuit #1665 - [x] 0x04 identity - [x] spec https://github.com/privacy-scaling-explorations/zkevm-specs/issues/321 - [x] circuit #1396 - [ ] 0x05 modexp...

ChihChengLiang

Use logging instead of raw printing for prover workspace member reports

4

Currently, we are just printing the info of the CLI bin with `println!`. But @ed255 introduced some time ago logging into the workspace. So it would be nice to use...

CPerezz

The `LtChip` defined in `gadgets/src/less_than.rs` uses this constrain: `lhs - rhs = diff - lt * 2.pow(8*N)` where `diff = from_bytes(diff_bytes)` and `diff_bytes: [Column; N],` This constrain is only useful...

ed255

PR #873 targets this issue .

DreamWuGit

ntampakas

Required opcodes for basic L2 Bridge

2

###### required environmental opcodes for L2 Bridge - [x] CALLVALUE https://github.com/appliedzkp/zkevm-circuits/pull/287 - [x] CALLDATASIZE https://github.com/appliedzkp/zkevm-circuits/pull/329 - [x] CALLDATALOAD https://github.com/appliedzkp/zkevm-circuits/pull/346 - [x] CALLDATACOPY https://github.com/appliedzkp/zkevm-circuits/pull/393 - [x] ORIGIN https://github.com/appliedzkp/zkevm-circuits/pull/360 - [x] CALLER...

pinkiebell

math gadgets refactory, for better code structure and unit test coverage.

1

The unit test task was initialized by #586, and we already created a unit test framework PR #865 . However, as the comment tells. > @smtmfft IMO we should also...

smtmfft