zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Published 20 hours ago • verified publisher icon privacy-scaling-explorations

Super circuit integration tests should use actual prover

Open leolara opened this issue 3 years ago • 2 comments

The super circuit was added after this task was started https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/789 so we should give it support for super circuit.

leolara avatar Dec 06 '22 06:12 leolara

Note: Will keep the duality of mock prover vs real prover

andyguzmaneth avatar Dec 08 '22 12:12 andyguzmaneth

A big part of this task is already complete via https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/878. The missing bits are:

  • [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/966
  • [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/967
  • [x] https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/968
  • [ ] Get all tests with real prover to pass (some unidentified fixes required)

ed255 avatar Dec 13 '22 16:12 ed255

Needs Blocked by https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/967

andyguzmaneth avatar Feb 02 '23 12:02 andyguzmaneth

Update: currently the keccak circuit is failing with the real prover but not the mock prover. The latest mock prover has strict checks to verify correctness of using the Challange API, but Han found that in the zkevm-circuits we're not using the last version of the mock prover, so we're not using this checks! The keccak circuit failure is probably resolved by this https://github.com/scroll-tech/zkevm-circuits/pull/308

ed255 avatar Mar 09 '23 12:03 ed255

The last task will be resolved with this PR https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1315

davidnevadoc avatar Mar 21 '23 10:03 davidnevadoc

Closed by #1315

davidnevadoc avatar Mar 28 '23 21:03 davidnevadoc