zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Published 20 hours ago • verified publisher icon privacy-scaling-explorations

pi circuit updates

Open pinkiebell opened this issue 3 years ago • 3 comments

This includes changes that are used in zkevm-chain. The pi circuit spec changed in between and this PR doesn't account for these changes.

pinkiebell avatar Nov 25 '22 09:11 pinkiebell

👋 Comment on this pull request with /test to trigger the integration tests.

github-actions[bot] avatar Nov 25 '22 09:11 github-actions[bot]

@ed255 I created this PR even if this conflicts with #730 just for tracking purposes. If the circuit optimizations gets merged, then I can reflect these changes for the evm contracts. Let me know how to proceed here 👌

pinkiebell avatar Nov 25 '22 09:11 pinkiebell

@ed255 I created this PR even if this conflicts with #730 just for tracking purposes. If the circuit optimizations gets merged, then I can reflect these changes for the evm contracts. Let me know how to proceed here ok_hand

Sorry I missed this message.

https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/730 has been merged! I see that it included the call_data_gas (now called call_data_gas_cost). So I think you can update this PR accordingly

ed255 avatar Dec 08 '22 10:12 ed255

@ed255 Now that zkevm-chain uses the latest Pi circuit, I rebased this pr and only added rand_rpi to the mix.

pinkiebell avatar Feb 06 '23 14:02 pinkiebell