zkevm-circuits
zkevm-circuits copied to clipboard
State circuit spec sync
Describe the feature you would like
This issue collects the list of feedback to work on from https://github.com/privacy-scaling-explorations/zkevm-specs/pull/520
The file to modify is zkevm-circuits/src/circuit_tools/constraint_builder.rs
- value_prev and value_prev_column are confusing names. @rrtoledo Suggest renaming them to:
value_prev: WordLoHi<Expression>, // meta.query(value, Rotation::prev())could be renamed value_rot_prev for instancepub value_prev_column: WordLoHi<Expression>, // meta.query(prev_value, Rotation::cur())be renamed value_prev
- https://github.com/privacy-scaling-explorations/zkevm-specs/pull/520#discussion_r1553259772
TBD
Additional context
No response