zkevm-circuits icon indicating copy to clipboard operation
zkevm-circuits copied to clipboard

Published 20 hours ago • verified publisher icon privacy-scaling-explorations

[MPT - stack trie] fix witness generation

Open KimiWu123 opened this issue 1 year ago • 2 comments

Describe the feature you would like

There was an implementation under mpt-witness-generator/trie/stacktrie.go already, but still has some bugs. This issue is mainly to fix it. See Miha's doc for more details.

Additional context

No response

KimiWu123 avatar Feb 05 '24 06:02 KimiWu123

This is partially resolved by https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1779, but would be good to add some further tests which would test GetProof more extensively, especially for the hashed trie (like TestGetProof). Also, it would be nice to have some tests that check whether the number of proof elements (for elements with a bigger depth) is as expected and the leaf (the last proof element) is as expected...

miha-stopar avatar Feb 23 '24 11:02 miha-stopar

Update: #1784 was to add testing for GetProof #1789 was to export json file for circuit

KimiWu123 avatar Mar 08 '24 06:03 KimiWu123