zkevm-circuits
zkevm-circuits copied to clipboard
privacy-scaling-explorations
Some types of error,ErrDepth and ErrInsufficientBalance, will not hang, but do nothing and continue execution. So transition from these errors to BeginTx is impossible. https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/c78c86dfb7bc9198c0e7b0fcc5e7ecfd21277893/zkevm-circuits/src/evm_circuit/execution.rs#L672
for tables like tx table and keccak table, when we change the table layout later, we need to change codes both in dev_load and real assignment. Maybe error prone
Currently in testool we have repeated code to parse types holding words, addresses, etc. for json and yaml: - https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/673f5fe6e9e76ce3796a3f5b1d15d7c49ced66cd/testool/src/statetest/json.rs#L298 - https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/673f5fe6e9e76ce3796a3f5b1d15d7c49ced66cd/testool/src/statetest/yaml.rs#L292 We can unify the parsers by implementing a...
Currently the CopyCircuit contains a column called `value`. When the dest is of type `CopyDataType::RlcAcc`, the read rows contain read bytes, and the write rows contain the accumulated RLC of...
- multiple txs == MAX_TXS - multiple txs < MAX_TXS - max_rws padding - evm_rows padding
The super circuit was added after this task was started https://github.com/privacy-scaling-explorations/zkevm-circuits/issues/789 so we should give it support for super circuit.
This PR covers the case when extension node is inserted at the place of the existing extension node. The old extension node gets modified - it now has a different...
spec PR https://github.com/privacy-scaling-explorations/zkevm-specs/pull/301 - [x] merge stack overflow and underflow error to one `ErrorStack` - [x] construct op code stack table and circuit constraint - [x] overflow and underflow tests...
