pse.dev icon indicating copy to clipboard operation
pse.dev copied to clipboard

btw (out of scope of this PR), have you considered using an enum for this?

Open kalidiagne opened this issue 1 year ago • 1 comments
trafficstars

          btw (out of scope of this PR), have you considered using an enum for this?
  projectStatus: ProjectStatus.Inactive,

which would be defined in @/lib/types

As a dev not familiar with this repo, I had to look for a project which I knew was inactive and check for its data to know what exact string to use. No big deal, but an enum would force doing the right thing automatically.

Originally posted by @sripwoud in https://github.com/privacy-scaling-explorations/pse.dev/pull/186#discussion_r1721718778

kalidiagne avatar Aug 20 '24 00:08 kalidiagne

Makes sense to me 👍

samajammin avatar Sep 19 '24 02:09 samajammin

Closing as is fixed by https://github.com/privacy-scaling-explorations/pse.dev/pull/197

kalidiagne avatar Oct 18 '24 01:10 kalidiagne