test(core): remove msgTree

[samajammin]

trafficstars

Description

Remove msgTree variable

Confirmation

• [x] I have read and understand MACI's contributor guidelines and code of conduct.
• [x] I have read and understand MACI's GitHub processes.
• [x] I have read and understand MACI's testing guide.

[netlify[bot]]

✅ Deploy Preview for maci-typedoc ready!

Name	Link
🔨 Latest commit	16abc752f6495bf6149a86b5cfd2262efe7430f1
🔍 Latest deploy log	https://app.netlify.com/sites/maci-typedoc/deploys/658f0093bc6620000835649d
😎 Deploy Preview	https://deploy-preview-938--maci-typedoc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[samajammin]

@ctrlc03 this is mostly for my understanding...

Why are we creating this msgTree object? Don't we want to be comparing the state of the poll object in this test?

[ctrlc03]

@ctrlc03 this is mostly for my understanding... Why are we creating this msgTree object? Don't we want to be comparing the state of the poll object in this test?

@samajammin Great catch, you are absolutely right 🙂 ps. I have been thinking that we could probably remove the AccQueue instances throughout the core package tests and keep the IncrementalQuinTree instead to do the root checks (as that's what we use inside the Poll contract for storing message hashes) - what you think? if you like the idea maybe this PR could be extended to do that

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
maci-website	✅ Ready (Inspect)	Visit Preview	Jun 14, 2024 11:49am