maci icon indicating copy to clipboard operation
maci copied to clipboard

Check lint in CI

Open baumstern opened this issue 3 years ago • 2 comments

This is a naive implementation that checks if the build and lint passes.

baumstern avatar Mar 23 '22 08:03 baumstern

@gurrpi Is this PR still relevant? It looks like we have checks already for v1

corydickson avatar Jun 07 '22 21:06 corydickson

@gurrpi Is this PR still relevant? It looks like we have checks already for v1

This PR introduces check lint errors. I will change the PR name to make it more clear. Also filed an issue(https://github.com/privacy-scaling-explorations/maci/issues/457) for current lint errors.

baumstern avatar Jun 09 '22 13:06 baumstern

@gurrpi is this still something we want to merge?

samajammin avatar Oct 16 '23 17:10 samajammin

@gurrpi is this still something we want to merge?

Closing this due to its age and existing lint errors in our codebase. For lint checks in CI, a new, updated PR would be more appropriate.

baumstern avatar Oct 16 '23 17:10 baumstern