maci icon indicating copy to clipboard operation
maci copied to clipboard

restructure imt folders in the circuit package

Open ctrlc03 opened this issue 1 year ago • 9 comments

Restructure folders to have one file per each template

ctrlc03 avatar May 02 '24 16:05 ctrlc03

Hey @ctrlc03, would love to work on this ?

0xshikhar avatar Oct 01 '24 09:10 0xshikhar

Hey @ctrlc03, would love to work on this ?

sure thing, can assign you @0xshikhar thanks

ctrlc03 avatar Oct 03 '24 13:10 ctrlc03

Hey @0xshikhar, are you still working on this? want to see if we can add it to the hackthoberfest

crisgarner avatar Oct 09 '24 13:10 crisgarner

Yup, started working on this. Was quite busy due to ETHKL

0xshikhar avatar Oct 10 '24 11:10 0xshikhar

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

0xshikhar avatar Oct 14 '24 19:10 0xshikhar

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

Hi @0xshikhar - this would be for the circuits folder not the ts code: https://github.com/privacy-scaling-explorations/maci/tree/dev/packages/circuits/circom/trees

ctrlc03 avatar Oct 17 '24 08:10 ctrlc03

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

0xshikhar avatar Oct 18 '24 08:10 0xshikhar

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

@0xshikhar I believe the original idea of this issue was to have one file for each template inside that folder. So if you open https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/circuits/circom/trees/incrementalMerkleTree.circom you can see there's different templates.

ctrlc03 avatar Oct 20 '24 09:10 ctrlc03

hi @0xshikhar checking if you still working on this issue?

ctrlc03 avatar Dec 02 '24 17:12 ctrlc03

hey @ctrlc03 , it seems nobody is working on this, I really want to work on this, can you please assign it to me? I will try to solve this one asap.

alisonhawk avatar Mar 20 '25 11:03 alisonhawk

assiged @alisonhawk - thank you

ctrlc03 avatar Mar 20 '25 11:03 ctrlc03

@ctrlc03 I have sent the PR regarding the chore and it seems previous PR has been closed. Can you please check and lemme know?

knelsondev avatar Apr 12 '25 20:04 knelsondev