halo2
halo2 copied to clipboard
doc: add comments to permutation prover structs
Description
Document the permutation prover types, in halo2_backend
Related issues
Resolve #264
Changes
- add comments to
CommittedSet,CommittedandEvaluatedstructs inhalo2_backend/plonk/permutation/prover.rs
@davidnevadoc Can you take a look at the PR? It's a tiny PR for documentation. So, I think we can merge this before new release.
Mark as draft until new release.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.99%. Comparing base (
7c368af) to head (e817f27).
Additional details and impacted files
@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 85 85
Lines 18684 18684
=======================================
Hits 15880 15880
Misses 2804 2804
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Doc looks good but I find the struct names somewhat confusing (not changed in this PR). In particular,
Committedbeing aVecofCommittedSetand not the other way around seems very counter intuitive. Thoughts on this @adria0 @guorong009 ? Other than that, LGTM 👍
Yes, they are very counter intuitive.
How about renaming the CommittedSet?
eg. PermPolyCommitted, SinglePolyCommitted, CommittedSingle