python-kit
python-kit copied to clipboard
prismicio
Determanistic url params
The URL parameters should be deterministic as the full URL is used as the key for caching. If the non-ordered dictionary is used the caching will miss even when a value has been stored.
I've also converted the max age from what I assume is milliseconds into seconds, which Python requires.
The Prismic API is sending very high expiry times (10 years) for articles, which makes it seem like it's using milliseconds rather than seconds. Some caching libraries (including AppEngine Memcache) sees this 10 year value as an error and refuses to store or retrieve the cached value.
Is there any update on this? Currently we're using a forked version of this library to work around this issue.
Hi,
I'm fine for the deterministic order, but I don't want to change milliseconds to seconds because it would break existing things and be inconsistent with API in other languages.
Could you separate them?
That should be just the URL change now. Once this is merged in, can you push a release please.