language-tools icon indicating copy to clipboard operation
language-tools copied to clipboard

`@prisma/language-server` versions overlap for versions that are for Insider vs. stable version

Open janpio opened this issue 4 years ago • 1 comments

During the release process of the VSCode extension for Prisma CLI 3.0.1 workflow 3 unexpectedly crashed. Turned out there is an overlap in the versioning scheme now we start with lower minor versions again:

  • Prisma (stable) 3.0.1 (for Prisma CLI 3.0.1) => @prisma/[email protected]
  • Prisma Insider 3.0.1 (for Prisma CLI 2.3.1-dev.1) => @prisma/[email protected] (from a looong time ago)

This leads to a crash in "3. Unit tests for LSP and publish" as the npm publish does not work.

(The overlapping version numbers "make sense" as the @prisma/language-server version is tightly coupled with the version string of the VSCode extension. We did not anticipate any problem back when we make the decision to just take both versions, both the one of the Insiders and the stable extension, and apply it to the Npm package. That was a mistake in hindsight)

Workaround

  1. Manually increase the version of packages/language-server/package.json (and package-lock.json) (e.g. +100 on the patch to make it 3.0.101)
  2. Disable workflow "6. Build Extension"
  3. Trigger "3. Unit tests for LSP and publish" again with new version 3.0.101
  4. Workflow 5 can not trigger Workflow 6 and fails
  5. Reenable workflow 6
  6. Trigger workflow 6 manually with the original version number (3.0.1) to finish the build and publish.

janpio avatar Sep 07 '21 18:09 janpio

Added some tests in https://github.com/prisma/language-tools/pull/895

Overlap happened with Prisma latest 3.0.1 & 3.1.1

Because calculated npm version is published for @prisma/language-server package see: https://www.npmjs.com/package/@prisma/language-server?activeTab=versions

Tests here show it will be the last overlap happening for 3.x

This will repeat with 4.0 and 4.1, 5.0 and 5.1 until version 31 if nothing is done about it. https://github.com/prisma/language-tools/issues/868

Jolg42 avatar Sep 30 '21 08:09 Jolg42