language-tools icon indicating copy to clipboard operation
language-tools copied to clipboard

Consistently seeing "You have both the Insider and stable Prisma VSCode extension installed..." on Insider installation

Open matthewmueller opened this issue 4 years ago • 3 comments

Bug description

Not sure if it's just me, but with the insiders edition, I consistently see:

You have both the Insider and stable Prisma VSCode extension installed. Please uninstall or disable one of them for a better experience.

Here's a screenshot

CleanShot 2021-03-25 at 11 37 09@2x

How to reproduce

Not sure if it's just me, but this is how I reproduce it.

  1. Install Insider's edition, uninstall stable version
  2. Restart VSCode.

Expected behavior

I should only see that message if I have both installed.

Environment & setup

  • OS: OSX
  • Editor: VSCode
  • Editor version: 1.54.3
  • Extension version: v20.0.25

matthewmueller avatar Mar 25 '21 10:03 matthewmueller

I can reproduce this. VSCode doesn't clean up because if you redownload, it will use the cache .vscode/extentions/{extension-id} and we depending on this to check for this case: https://github.com/prisma/language-tools/blob/94df49c2c3ebfca3e6f5c532382ccd59020422da/packages/vscode/src/util.ts#L37

So you can fix this for now by removing the prisma.prisma-{version} from ~/.vscode/extension

pantharshit00 avatar Mar 25 '21 13:03 pantharshit00

Can we improve our detection of this somehow?

janpio avatar Mar 25 '21 16:03 janpio

We need to perform a different check here. Maybe need to research more on where vscode actually stores the extension state.

pantharshit00 avatar Mar 26 '21 09:03 pantharshit00