Po Chen

Results 151 comments of Po Chen
trafficstars

We are going to add rest API in a bit. That will allow scripting side of IaC. Probably not from environment, unless many people ask for it or Jamil has...

Probably don't merge this one if you are making a release soon. This PR builds a skeleton of REST API but is far from production ready. However, this is where...

@jamilbk you might want to give this branch a go. Test it with a different provider. Get a feeling of what needs to go into the UI. Also see how...

If you don't have the time this week, my plan is to test onelogin next week and look at how SCIM plays in this.

Updated PR description with onelogin

The important things I'd like your thoughts on are: 1. if fz_http turns into a SaaS at some point, we probably need auth configs saved per account / tenant? 2....

> Quick glance through. Looks good! Surprisingly (deceptively?) simple. Yeah, the package did most of the heavy lifting. The majority of the work was exploring how to wire the configs...

@jamilbk this is basically feature complete now. Please take a look. Next I'm going to add tests, add auto gen certs and cleanup. To test this feature, run `docker-compose exec...

Thanks for the initial review. Great timing as well. I was just starting to work on the rest of the PR.

You will notice the lack of SAML workflow test. Instead of mocking absolutely everything and generating fake XML response, I'd rather leave the testing to future staging/QA e2e tests.