distinction in css colors

[la-magbanua]

First of all this theme has been my daily driver, it's too good! One thing I've noticed though is that the CSS property and value sometimes could be hard to differentiate. Would be nice and easier to scan with the eyes if the shade or tint would be adjusted. Appreciate the work, thank you!

[simurai]

This theme tries to stay close to the highlighting here on github.com.

I do see a difference when the language is set to .css:

main {
  flex: 1;
  position: relative;
}

But when using .scss, this theme matches:

main {
  flex: 1;
  position: relative;
}

Not sure how high priority this is but it would be nice to align it a bit more.

[la-magbanua]

Would be cool if this got color distinction as well...

[macintacos]

I know that we're trying to keep as close to GitHub's dark theme, but maybe that needs to be improved as well (I'm not sure where to direct that bit of feedback, but may as well do it here). This CSS syntax highlighting is barely better than just plaintext:

Constrast with something like the Dracula theme, where separators, key/value pairs, strings, etc. at least have contrasting colors enough so that it's visually easier (for me of course) to parse:

Surely CSS could be handled better than it currently is?

[simurai]

This CSS syntax highlighting is barely better than just plaintext

Yeah, especially for scss:

.class.one-more-class:hover {
  color: red;
  background-color: #123456;
}

There is a discussion regarding the question if it's ok for this theme to improve highlighting even if it starts to deviate from github.com: https://github.com/primer/github-vscode-theme/discussions/147

[arlorose]

Any movement on this decision?

I just discovered this theme today and love it, but CSS is unusable. Just adding my voice here, but will also likely branch the theme and alter it so CSS is usable for me. :-)