prettier-browser-extension icon indicating copy to clipboard operation
prettier-browser-extension copied to clipboard

Published 20 hours ago • verified publisher icon prettier

Testing content

Open nickserv opened this issue 6 years ago • 4 comments

#53

  • [x] Test basic button injection
  • [x] Create fully-functioning stubs
    • [x] chrome.extension.storage.sync
    • [x] MutationObserver
  • [x] Attempt to test with mocked window.location
  • [x] Test option loading behavior
  • [x] Consider adding more granular unit tests per class/file/method/function
  • [x] Consider using dom-testing-library for better assertions and consistency with #87
  • [ ] ~~Complete test coverage~~

nickserv avatar Nov 07 '19 17:11 nickserv

Can we fix the merge conflicts and merge this? If everything is set up, I don't think we need to wait until we have complete coverage before merging.

kaicataldo avatar Aug 20 '20 00:08 kaicataldo

Friendly ping.

kaicataldo avatar Aug 26 '20 05:08 kaicataldo

I'm going to see if I can swap in sinon-chrome similarly to #87 before I merge this. Maintaining mocks manually is a lot of churn.

nickserv avatar Aug 30 '20 01:08 nickserv

Are you still working on this? If not, I think it would be best to close the PR for now so others can feel free to work on it (would love to land this PR if you're still working on it, though!).

kaicataldo avatar Feb 01 '21 05:02 kaicataldo