plugin-xml icon indicating copy to clipboard operation
plugin-xml copied to clipboard

move comment before

Open xenoterracide opened this issue 1 year ago • 4 comments

given

    <module name="IllegalImport" /><!-- defaults to sun.* packages -->

I would like the reformat to be

    <!-- defaults to sun.* packages -->
    <module name="IllegalImport" />

instead of

    <module name="IllegalImport" />
    <!-- defaults to sun.* packages -->

note: obviously I've turned off whitespace sensitivity.

I feel like this would be a sensible default with whitespace sensitivity turned off, but an option would be nice too. I feel like programming convention is, comments to the right affect code to the left. Comments before affect code below. So moving the comment to be after changes the ... semantics.

Alternative, or maybe in addition to, if you could leave the comment alone if it's not making the line too long.

xenoterracide avatar Mar 28 '24 02:03 xenoterracide

I would also love that...

Even better, if I could make a wish, ideally, by default, move it on top and optionally, preserve it as it is.

fbridault avatar Apr 23 '24 08:04 fbridault

I'm not going to make a configuration option for this, but I am open to changing the default behavior here. Are we okay with saying that:

<foo /><!-- bar -->

gets reformatted to:

<!-- bar -->
<foo />

but

<foo /> <!-- bar -->

stays the same? As in, they have to be "touching" in order to get this special behavior?

kddnewton avatar Apr 23 '24 12:04 kddnewton

Thank you for your answer. Yes, for me that would look perfectly acceptable!

fbridault avatar Apr 23 '24 15:04 fbridault

Works for me

xenoterracide avatar Apr 23 '24 20:04 xenoterracide