fix: Back out "[Diff Train][prestodb/presto] Apply fixup patch to fbsource"

[Sullivan-Patrick]

Summary: This broke a bunch of tests.

Reviewed By: macvincent

Differential Revision: D88879226

[linux-foundation-easycla[bot]]

• :x: The email address for the commit (96ac95ccdb753108d7d4380981fdc6e41d6fd61c) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[sourcery-ai[bot]]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts parts of a previous change by simplifying several catch blocks: it removes unused exception variable bindings while preserving the existing error-handling behavior across tests, task handling, server operations, HTTP responses, and exchange/shuffle operators.

File-Level Changes

Change	Details	Files
Remove unused exception variable names from catch blocks while preserving existing error-handling behavior.	In test code, catch VeloxUserError by type only and fall back to parsing string values without inspecting the exception. In task creation/update logic, catch VeloxException and VeloxUserError by type only, still rethrowing or wrapping as before. In server operations and HTTP response helpers, catch std::exception by type without using the exception instance, keeping the same failure paths and messages. In broadcast and shuffle exchange/write components, catch VeloxException by type and rethrow, leaving downstream error conversion to existing handlers.	presto-native-execution/presto_cpp/main/tests/PrestoToVeloxQueryConfigTest.cpp presto-native-execution/presto_cpp/main/TaskResource.cpp presto-native-execution/presto_cpp/main/PrestoServerOperations.cpp presto-native-execution/presto_cpp/main/http/HttpServer.cpp presto-native-execution/presto_cpp/main/operators/BroadcastExchangeSource.cpp presto-native-execution/presto_cpp/main/operators/ShuffleExchangeSource.cpp presto-native-execution/presto_cpp/main/operators/ShuffleWrite.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[tdcmeehan]

"[Diff Train][prestodb/presto] Apply fixup patch to fbsource" doesn't seem to be a commit in this project. Can you help clarify what is being backed out?